Skip to content

Conversation

@satsukies
Copy link
Member

@satsukies satsukies commented Jan 31, 2025

The regex pattern "\d.\d.\d" didn't match if any digit value was larger than 10.
So, we need to update the regex pattern according to the semantic versioning.

ref. https://semver.org/lang/ja/

version before after
4.9.0
4.9.0-alpha0
4.9.0-alpha1
4.9.0-alpha01
4.9.0-alpha10
4.9.1
4.9.10
4.10.0
4.10.10

@satsukies satsukies added the bug label Jan 31, 2025
@satsukies satsukies self-assigned this Jan 31, 2025
@satsukies satsukies requested a review from tnj January 31, 2025 03:36
Copy link
Member

@tnj tnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure

@satsukies satsukies requested a review from tnj January 31, 2025 06:39
Copy link
Member

@tnj tnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tnj tnj merged commit 5b8a633 into master Jan 31, 2025
6 checks passed
@tnj tnj deleted the fix/release-workflow-tag-regex branch January 31, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants