Specify export flag for Context-based receiver #72
+28
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatsu
commented
Jul 26, 2023
| working_directory: ~/deploygate-android-sdk | ||
| environment: | ||
| GRADLE_OPTS: '-Dorg.gradle.jvmargs="-Xmx2048m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError" -Dorg.gradle.daemon=false' | ||
| GRADLE_OPTS: '-Dorg.gradle.jvmargs="-Xmx2048m -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError" -Dorg.gradle.daemon=false' |
Contributor
Author
There was a problem hiding this comment.
MaxPermSize is no longer valid for JVM 9 or later
jmatsu
commented
Jul 26, 2023
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:4.2.2' | ||
| classpath 'com.akaita.android:easylauncher:1.3.1' | ||
| classpath 'com.android.tools.build:gradle:7.4.2' |
Contributor
Author
There was a problem hiding this comment.
To use Android SDK 33
satsukies
reviewed
Jul 27, 2023
|
|
||
| testImplementation 'androidx.test:rules:1.2.0' | ||
| testImplementation 'androidx.test:rules:1.5.0' | ||
| testImplementation 'com.google.truth:truth:1.0' |
Member
There was a problem hiding this comment.
truth:1.1.4 is now available. how about it updating?
see: https://truth.dev/
Suggested change
| testImplementation 'com.google.truth:truth:1.0' | |
| testImplementation 'com.google.truth:truth:1.1.4' |
Contributor
Author
There was a problem hiding this comment.
@satsukies
Please make a new PR. These updates are just for Android 14 SDK and JVM changes.
Member
There was a problem hiding this comment.
@jmatsu
I see. My comment was off the maintain of PR.
Contributor
Author
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been introduced since Android 13 SDK (https://developer.android.com/about/versions/13/features#runtime-receivers) and it's now required for apps that target Android 14 or later (https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported).
See the implementation of ContextCompat for the verification. https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core/src/main/java/androidx/core/content/ContextCompat.java;drc=b63ff8c4299a6486bf34ec2ac746517e2d378d43