Skip to content

A few device may not be able to read metaData of DeployGate application #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2024
Merged

A few device may not be able to read metaData of DeployGate application #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion sdk/src/main/java/com/deploygate/sdk/DeployGateClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import android.content.pm.Signature;
import android.content.pm.SigningInfo;
import android.os.Build;
import android.util.Log;

import com.deploygate.sdk.internal.Logger;

Expand Down Expand Up @@ -56,7 +57,16 @@ class DeployGateClient {
this.versionCode = info.versionCode;
}

this.featuresFlag = info.applicationInfo.metaData.getInt("com.deploygate.features", 0);
if (info.applicationInfo.metaData == null) {
// LG_G3 (OS 5.0, the build number is unknown)

this.featuresFlag = 0;

Log.w(Logger.TAG, "New features of DeployGate SDK may not be available on this device.");
Log.w(Logger.TAG, "This may happen on a few device when you use ContentProvider to initialize DeployGate SDK, then please initialize DeployGateSDK manually instead.");
Copy link
Member

@satsukies satsukies Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good message 👍

} else {
this.featuresFlag = info.applicationInfo.metaData.getInt("com.deploygate.features", 0);
}
} else {
this.isInstalled = false;
this.versionCode = 0;
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/main/java/com/deploygate/sdk/internal/Logger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import java.util.Locale;

public class Logger {
private static final String TAG = "DeployGateSDK";
public static final String TAG = "DeployGateSDK";

public static void d(
String format,
Expand Down