Add DeployGateSdkConfiguration class and DeployGate#install to sdkMock #84
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: Add a new testcase that uses these entities
We can also exclude this annotation in Javadoc step though, this tag doesn't make sense for now
satsukies
approved these changes
Mar 25, 2024
Member
satsukies
left a comment
satsukies
left a comment
There was a problem hiding this comment.
LGTM 👍
By the way, what tool we can use for automatic code-generation?
Contributor
Author
|
APT doesn't work in this case, so we may need to create our own tool that uses AST parser. |
Member
I see. Sounds like difficult 😨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #83
DeployGateSdkConfiguration class and DeployGate#install method appears only in com.deploygate.sdk artifact so those who use the entities would be faced with compilation errors on variants that use sdk-mock dependency.
This PR adds the classes above to sdkMock module as well.
BTW, to solve this issue completely, we must introduce automated code-generation tool to produce sdkMock classes instead of maintaining independently.