feat: collecting device states on SDK #97
Merged
+63
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satsukies
commented
Sep 17, 2024
| } | ||
|
|
||
| public void collectLocale() { | ||
| Locale defaultLocale = Locale.getDefault(); |
Member
Author
There was a problem hiding this comment.
We need to use AppCompat 1.6.0~ if we collect per-app language preferences with backward compatibility.
But we should avoid adding new dependencies, so I use Locale instead.
In the future, this implementation will be updated if we can collect by another way.
jmatsu
suggested changes
Sep 17, 2024
Comment on lines
25
to
59
| ArrayList<Pair<String, Object>> data = new ArrayList<>(); | ||
| data.add(new Pair<String, Object>("toString", defaultLocale.toString())); | ||
| data.add(new Pair<String, Object>("getLanguage", defaultLocale.getLanguage())); | ||
| data.add(new Pair<String, Object>("getCountry", defaultLocale.getCountry())); | ||
| data.add(new Pair<String, Object>("getVariant", defaultLocale.getVariant())); | ||
| data.add(new Pair<String, Object>("getDisplayCountry", defaultLocale.getDisplayCountry())); | ||
| data.add(new Pair<String, Object>("getDisplayLanguage", defaultLocale.getDisplayLanguage())); | ||
| data.add(new Pair<String, Object>("getDisplayName", defaultLocale.getDisplayName())); | ||
| data.add(new Pair<String, Object>("getDisplayVariant", defaultLocale.getDisplayVariant())); | ||
| data.add(new Pair<String, Object>("getISO3Country", defaultLocale.getISO3Country())); | ||
| data.add(new Pair<String, Object>("getISO3Language", defaultLocale.getISO3Language())); | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { | ||
| data.add(new Pair<String, Object>("getDisplayScript", defaultLocale.getDisplayScript())); | ||
| data.add(new Pair<String, Object>("toLanguageTag", defaultLocale.toLanguageTag())); | ||
| } | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { | ||
| data.add(new Pair<String, Object>("getScript", defaultLocale.getScript())); | ||
| } | ||
|
|
||
| putAll(Locale.class.getName(), data); | ||
| } | ||
|
|
||
| private void putAll(String fqcn, List<Pair<String, Object>> data) { | ||
| for (Pair<String, Object> pair : data) { | ||
| String key = String.format("%s$%s", fqcn, pair.first); | ||
| try { | ||
| states.put(key, pair.second); | ||
| } catch (JSONException e) { | ||
| Logger.w(e, "Failed to put info: key=%s, value=%s", key, pair.second); | ||
| } | ||
| } | ||
|
|
||
| } |
Contributor
There was a problem hiding this comment.
Please put a pair one by one instead of collecting pairs and put them at once. It may be a cost to hold many pairs and iterate them.
Member
Author
There was a problem hiding this comment.
I fix it on 3a6113e.
Rename "putAll" method to "put" and reuse the implementation of handing JSONException with try-catch block. We should handle that for each put operation not whole operations.
satsukies
commented
Sep 19, 2024
| long elapsedRealtime, | ||
| TimeUnit timeUnit | ||
| ) { | ||
| getSdkDeviceStatesCollector().collectLocale(); |
Member
Author
There was a problem hiding this comment.
We collect Locale information when the host app becomes foreground.
Member
Author
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect any device states when creating a capture.
Some attributes are collected on the host app better correctly.
(e.g. per-app language preference: https://developer.android.com/guide/topics/resources/app-languages?hl=ja )