Skip to content

Conversation

@satsukies
Copy link
Member

We will create a new release after this PR is merged.

@satsukies satsukies requested a review from jmatsu September 19, 2024 05:11
@satsukies satsukies self-assigned this Sep 19, 2024
@jmatsu
Copy link
Contributor

jmatsu commented Sep 19, 2024

@satsukies
I'm sorry for missing points on your PR. SdkDeviceStatesCollector should be thread-safe for reading/writing attributes. This could be a release blocker.

https://github.com/DeployGate/deploygate-android-sdk/blob/7459c6668d892a1b9e08aa26de5652b30cedaee7/sdk/src/main/java/com/deploygate/sdk/SdkDeviceStatesCollector.java

@satsukies
Copy link
Member Author

@jmatsu
I fixed it on #99 .
Please check and review it. Thanks.

@satsukies
Copy link
Member Author

This PR was automatically closed unexpectedly :(
So I reopen this.

@satsukies satsukies reopened this Sep 19, 2024
Copy link
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🎉

@satsukies
Copy link
Member Author

Thank you!

@satsukies satsukies merged commit 2ca2262 into master Sep 24, 2024
@satsukies satsukies deleted the chore/bumpup-version-4.9.0 branch September 24, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants