feat(select): 重构use-select.ts文件，拆分特性 #1128
Conversation
|
PR preview has been successfully built and deployed to https://vue-devui-pr-1128.surge.sh. |
packages/devui-vue/devui/select/src/composables/use-filter-select.ts
Outdated
Show resolved
Hide resolved
|
PR preview has been successfully built and deployed to https://vue-devui-pr-1128.surge.sh. |
|
PR preview has been successfully built and deployed to https://vue-devui-pr-1128.surge.sh. |
packages/devui-vue/devui/select/src/composables/use-allow-create.ts
Outdated
Show resolved
Hide resolved
|
PR preview has been successfully built and deployed to https://vue-devui-pr-1128.surge.sh. |
| } else { | ||
| checkedItems.push(item.value); | ||
| } | ||
| modelValue = checkedItems; |
There was a problem hiding this comment.
props的数据流应该是单向流动的，在子组件中修改父元素props的值，会报warning吧？
| const { filterQuery, isSupportFilter, injectOptionsArray, t } = option; | ||
|
|
||
| // no-data-text | ||
| const isLoading = computed(() => typeof props.loading === 'boolean' && props.loading); |
There was a problem hiding this comment.
这里建议不对props.loading进行是否为boolean的检查，可以消除isLoading中间变量，直接使用props.loading。可以讨论一下，当用户传入的loading值为一个非空的字符串或者数字的时候，我们是否希望loading是工作的？
| // no-data-text | ||
| const isLoading = computed(() => typeof props.loading === 'boolean' && props.loading); | ||
| const emptyText = computed(() => { | ||
| const visibleOptionsCount = injectOptionsArray.value.filter((item) => { |
There was a problem hiding this comment.
visibleOptionsCount主要是用来判断是否存在visibleOptions，所以是否可以将名字改为hasVisibleOptions，同时后面的filter方法替换为some方法。
| }); | ||
|
|
||
| const isShowEmptyText = computed(() => { | ||
| return !!emptyText.value && (!props.allowCreate || isLoading.value || (props.allowCreate && injectOptionsArray.value.length === 0)); |
There was a problem hiding this comment.
这里的判断条件有些复杂，存在&&与||的嵌套，建议填加注释，不然比较难读懂。
| // allow-create | ||
| const isShowCreateOption = computed(() => { | ||
| const hasCommonOption = injectOptionsArray.value.filter((item) => !item.create).some((item) => item.name === filterQuery.value); | ||
| return props.filter === true && props.allowCreate && !!filterQuery.value && !hasCommonOption; |
| filterQuery.value = ''; | ||
| } | ||
| if (isSupportFilter.value) { | ||
| focus(); |
There was a problem hiding this comment.
focus方法在当前文件没有找到声明的位置，此处是如何工作的？
|
@daviForevel 有冲突和检视意见未解决 |
|
@daviForevel 这个PR的冲突和检视意见太久未解决，先关闭了 |
4 participants
No description provided.