checkbox 组件 size 大小使用scss变量向标准统一 #1199 #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vaebe
commented
Sep 7, 2022
vaebe
commented
- checkbox 组件 size 大小使用scss变量向标准统一 🐛 [Bug]: Button、Search、Input、InputNumber、InputIcon、Select等支持设置size的组件标准不一 #1199
- checkbox-group 组件 direction 排列方向样式优化
- checkbox组件文档更新 去除组件 size xs 类型及相关组件示例，按钮形态示例优化
|
PR preview has been successfully built and deployed to https://vue-devui-pr-1321.surge.sh. |
kagol
approved these changes
Sep 7, 2022
Member
|
@vaebe 可以一起讨论下 Radio 和 Checkbox 有什么办法实现一定程度的复用，我看很多代码都是重复的 |
Collaborator
Author
可以考虑实现一个 group 的组件🤪 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.