Skip to content

Add @angular/forms to peerDependency #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2017
Merged

Add @angular/forms to peerDependency #374

merged 2 commits into from
Feb 10, 2017

Conversation

@Aden-git
Copy link
Contributor

@Aden-git Aden-git commented Feb 9, 2017

We use this dependency in our CustomValueAccessor implementation, so it should be mentioned in pearDependency list.

@Aden-git Aden-git requested a review from ovchinnikov February 9, 2017 18:23
@Aden-git Aden-git changed the title Add @angular/form to peerDependency Add @angular/forms to peerDependency Feb 10, 2017
@Aden-git Aden-git merged commit b26a3b9 into master Feb 10, 2017
@Aden-git Aden-git deleted the PeerDependency_changes branch February 22, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ovchinnikov ovchinnikov ovchinnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aden-git @ovchinnikov