Skip to content

Bump MSTest from 3.10.2 to 4.0.0 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2025
Merged

Bump MSTest from 3.10.2 to 4.0.0 #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c58714c
Bump MSTest from 3.10.2 to 4.0.0
dependabot[bot] Oct 13, 2025
15177aa
Merge branch 'main' into dependabot/nuget/tests/NetDaemon.Extensions.…
DevJasperNL Oct 13, 2025
445c7b6
Using Assert.IsTrue and Assert.IsFalse rather than Assert.AreEqual.
DevJasperNL Oct 15, 2025
2e3aede
Using Assert.IsEmpty instead of Assert.AreEqual.
DevJasperNL Oct 15, 2025
86edef1
Explicitly setting Parallelize
DevJasperNL Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...Extensions.Observables.Tests/EntityExtensions.ToBooleanObservable.ConcreteEntity.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public void ToChangesOnlyBooleanObservable_Predicate_InitiallyDoesNotReturnState
_testEntity.ToChangesOnlyBooleanObservable(s => s.IsOff()).Subscribe(results.Add);

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}

[TestMethod]
Expand Down Expand Up @@ -170,7 +170,7 @@ public void ToChangesOnlyBooleanObservable_Predicate_NullIgnored()
EntityStateNull();

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}

public record TestEntity : Entity<TestEntity, EntityState<TestEntityAttributes>, TestEntityAttributes>
Expand Down
10 changes: 5 additions & 5 deletions ...tDaemon.Extensions.Observables.Tests/EntityExtensions.ToBooleanObservable.Entity.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public void ToChangesOnlyBooleanObservable_InitiallyDoesNotReturnState()
_testEntity.ToChangesOnlyBooleanObservable().Subscribe(results.Add);

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}

[TestMethod]
Expand Down Expand Up @@ -254,7 +254,7 @@ public void ToChangesOnlyBooleanObservable_OtherStatesAreIgnored()
ChangeEntityState("Something else");

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}

[TestMethod]
Expand All @@ -268,7 +268,7 @@ public void ToChangesOnlyBooleanObservable_NullIgnored()
EntityStateNull();

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}

[TestMethod]
Expand All @@ -281,7 +281,7 @@ public void ToChangesOnlyBooleanObservable_Predicate_InitiallyDoesNotReturnState
_testEntity.ToChangesOnlyBooleanObservable(s => s.IsOff()).Subscribe(results.Add);

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}

[TestMethod]
Expand Down Expand Up @@ -325,6 +325,6 @@ public void ToChangesOnlyBooleanObservable_Predicate_NullIgnored()
EntityStateNull();

// Assert
Assert.AreEqual(0, results.Count);
Assert.IsEmpty(results);
}
}
12 changes: 6 additions & 6 deletions ...EntityExtensions.ToBooleanObservable.Scheduling.LimitTrueDuration.ConcreteEntity.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void LimitTrueDuration_Predicate_LastChangedShorterAgoThanTimeSpan_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -41,7 +41,7 @@ public void LimitTrueDuration_Predicate_LastChangedLongerAgoThanTimeSpan_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -60,7 +60,7 @@ public void LimitTrueDuration_Predicate_SubscribeAfterTimeSpanPasses_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -76,12 +76,12 @@ public void LimitTrueDuration_Predicate_LastChangedHalfwayOfTimeSpan_FalseAfterR
bool? result = null;
observable.Subscribe(b => result = b);

Assert.AreEqual(true, result);
Assert.IsTrue(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(true, result);
Assert.IsTrue(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}
}
24 changes: 12 additions & 12 deletions ...s.Tests/EntityExtensions.ToBooleanObservable.Scheduling.LimitTrueDuration.Entity.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public void LimitTrueDuration_LastChangedShorterAgoThanTimeSpan_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -34,7 +34,7 @@ public void LimitTrueDuration_LastChangedLongerAgoThanTimeSpan_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -49,7 +49,7 @@ public void LimitTrueDuration_SubscribeAfterTimeSpanPasses_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -63,13 +63,13 @@ public void LimitTrueDuration_LastChangedHalfwayOfTimeSpan_FalseAfterRemainingTi
bool? result = null;
observable.Subscribe(b => result = b);

Assert.AreEqual(true, result);
Assert.IsTrue(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(true, result);
Assert.IsTrue(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -88,7 +88,7 @@ public void LimitTrueDuration_Predicate_LastChangedShorterAgoThanTimeSpan_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -107,7 +107,7 @@ public void LimitTrueDuration_Predicate_LastChangedLongerAgoThanTimeSpan_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -126,7 +126,7 @@ public void LimitTrueDuration_Predicate_SubscribeAfterTimeSpanPasses_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -142,12 +142,12 @@ public void LimitTrueDuration_Predicate_LastChangedHalfwayOfTimeSpan_FalseAfterR
bool? result = null;
observable.Subscribe(b => result = b);

Assert.AreEqual(true, result);
Assert.IsTrue(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(true, result);
Assert.IsTrue(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}
}
12 changes: 6 additions & 6 deletions ...Tests/EntityExtensions.ToBooleanObservable.Scheduling.WhenTrueFor.ConcreteEntity.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void WhenTrueFor_Predicate_LastChangedShorterAgoThanTimeSpan_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -41,7 +41,7 @@ public void WhenTrueFor_Predicate_LastChangedLongerAgoThanTimeSpan_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -60,7 +60,7 @@ public void WhenTrueFor_Predicate_SubscribeAfterTimeSpanPasses_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -76,12 +76,12 @@ public void WhenTrueFor_Predicate_LastChangedHalfwayOfTimeSpan_TrueAfterRemainin
bool? result = null;
observable.Subscribe(b => result = b);

Assert.AreEqual(false, result);
Assert.IsFalse(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(false, result);
Assert.IsFalse(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}
}
24 changes: 12 additions & 12 deletions ...rvables.Tests/EntityExtensions.ToBooleanObservable.Scheduling.WhenTrueFor.Entity.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public void WhenTrueFor_LastChangedShorterAgoThanTimeSpan_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -33,7 +33,7 @@ public void WhenTrueFor_LastChangedLongerAgoThanTimeSpan_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -48,7 +48,7 @@ public void WhenTrueFor_SubscribeAfterTimeSpanPasses_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -62,13 +62,13 @@ public void WhenTrueFor_LastChangedHalfwayOfTimeSpan_TrueAfterRemainingTime()
bool? result = null;
observable.Subscribe(b => result = b);

Assert.AreEqual(false, result);
Assert.IsFalse(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(false, result);
Assert.IsFalse(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -87,7 +87,7 @@ public void WhenTrueFor_Predicate_LastChangedShorterAgoThanTimeSpan_False()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(false, result);
Assert.IsFalse(result);
}

[TestMethod]
Expand All @@ -106,7 +106,7 @@ public void WhenTrueFor_Predicate_LastChangedLongerAgoThanTimeSpan_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -125,7 +125,7 @@ public void WhenTrueFor_Predicate_SubscribeAfterTimeSpanPasses_True()
observable.Subscribe(b => result = b);

// Assert
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}

[TestMethod]
Expand All @@ -141,12 +141,12 @@ public void WhenTrueFor_Predicate_LastChangedHalfwayOfTimeSpan_TrueAfterRemainin
bool? result = null;
observable.Subscribe(b => result = b);

Assert.AreEqual(false, result);
Assert.IsFalse(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(false, result);
Assert.IsFalse(result);

Scheduler.AdvanceBy(1);
Assert.AreEqual(true, result);
Assert.IsTrue(result);
}
}
1 change: 1 addition & 0 deletions tests/NetDaemon.Extensions.Observables.Tests/MSTestSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[assembly: Parallelize(Scope = ExecutionScope.MethodLevel)]
2 changes: 1 addition & 1 deletion tests/NetDaemon.Extensions.Observables.Tests/NetDaemon.Extensions.Observables.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Reactive.Testing" Version="6.1.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="MSTest" Version="3.10.2" />
<PackageReference Include="MSTest" Version="4.0.0" />
<PackageReference Include="NetDaemon.HassModel" Version="25.36.0" />
<PackageReference Include="System.Reactive" Version="6.1.0" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...etDaemon.Notifications.InputSelect.Tests/NetDaemon.Notifications.InputSelect.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.1.0" />
<PackageReference Include="Microsoft.Testing.Extensions.TrxReport" Version="2.0.0" />
<PackageReference Include="MSTest" Version="3.10.2" />
<PackageReference Include="MSTest" Version="4.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down