feat(pages)!: require artifact-path input#207
Merged
Conversation
Remove the `"."` default from `artifact-path` and make it `required: true`. Defaulting to the repo root silently publishes everything (READMEs, configs, build metadata); callers should declare exactly what to publish. BREAKING CHANGE: callers of the reusable Pages workflow must now pass `artifact-path` explicitly (e.g. `artifact-path: "public"` or `"."`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
artifact-pathdefaulted to".", so a caller that doesn't set it silently publishes the entire repo root to GitHub Pages / Cloudflare — includingREADME.md, config files, lockfiles, and other repo internals. This makesartifact-pathrequired: true(no default) so every caller declares exactly what to publish.Changes
artifact-path:required: false+default: "."→required: true(default removed). Description unchanged.Breaking change
This is a breaking change to the reusable workflow: existing callers that relied on the
"."default must now passartifact-pathexplicitly. Marked withfeat(pages)!+ aBREAKING CHANGE:footer so release-please bumps the major version and Renovate won't automerge the bump for downstream consumers.Migration for callers:
The
DevSecNinja/edu-authconsumer is already updated to passartifact-path: "public", so it's ready for this once it bumps the pin.Validation
YAML parses; the change was diff-verified byte-identical against the current
mainfile with only theartifact-pathblock modified.