Skip to content

Fix to table query #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsmithnz merged 3 commits into from
May 22, 2023
Merged

Fix to table query #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1f53a2
Fix to table query
samsmithnz May 22, 2023
3b2fc83
Fix to test
samsmithnz May 22, 2023
1e87b77
Fix to include build time and pr time
samsmithnz May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DevOpsMetrics.Core/DataAccess/LeadTimeForChangesDA.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public static async Task<LeadTimeForChangesModel> GetGitHubLeadTimesForChanges(b
AverageBuildHours = averageBuildHours,
AveragePullRequestHours = leadTime,
LeadTimeForChangesMetric = leadTime + averageBuildHours,
LeadTimeForChangesMetricDescription = LeadTimeForChanges.GetLeadTimeForChangesRating(leadTime),
LeadTimeForChangesMetricDescription = LeadTimeForChanges.GetLeadTimeForChangesRating(leadTime + averageBuildHours),
PullRequests = utility.GetLastNItems(pullRequests, maxNumberOfItems),
NumberOfDays = numberOfDays,
MaxNumberOfItems = uiPullRequests.Count,
Expand Down
2 changes: 1 addition & 1 deletion src/DevOpsMetrics.Core/DataAccess/TableStorage/TableStorageCommonDA.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public List<AzureStorageTableModel> GetItems(string partitionKey)

// execute the query on the table
List<AzureStorageTableModel> list = table.CreateQuery<AzureStorageTableModel>()
//.Where(ent => ent.PartitionKey == partitionKey)
.Where(ent => ent.PartitionKey == partitionKey)
.ToList();

return list;
Expand Down
31 changes: 26 additions & 5 deletions src/DevOpsMetrics.Tests/Service/DORASummaryControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,39 @@ public void DORASummaryControllerGetIntegrationTest()
//Assert
Assert.IsNotNull(model);

}
[TestMethod]
public void DORASummaryControllerGetIntegrationTest2()
{
//Arrange
string organization = "samsmithnz";
string repository = "AzurePipelinesToGitHubActionsConverter";
DORASummaryController controller = new(base.Configuration);

//Act
DORASummaryItem model = controller.GetDORASummaryItem(organization, repository);

//Assert
Assert.IsNotNull(model);

}

[TestMethod]
public async Task DORASummaryControllerUpdateIntegrationTest()
{
//Arrange
string organization = "DeveloperMetrics";
string repository = "DevOpsMetrics";
string organization = "samsmithnz";
string repository = "AzurePipelinesToGitHubActionsConverter";
string branch = "main";
string workflowName = "1162561";
string workflowId = "1162561";
string resourceGroup = "DevOpsMetrics";
string workflowName = "CI/CD";
string workflowId = "38158";
string resourceGroup = "PipelinesToActions";
//string organization = "DeveloperMetrics";
//string repository = "DevOpsMetrics";
//string branch = "main";
//string workflowName = "CI/CD";
//string workflowId = "1162561";
//string resourceGroup = "DevOpsMetrics";
int numberOfDays = 30;
int maxNumberOfItems = 20;
DORASummaryController controller = new(base.Configuration);
Expand Down