Integrate paging for Topic Screen
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key changes: - Added `TopicPagingSource` to handle fetching paged data. - Modified `TopicViewModel` to use `Pager` for fetching and managing paged data. - Updated `TopicList` and `TopicScreenUI` to consume `LazyPagingItems`. - Added new dependencies for multiplatform paging (`cashapp-paging-common`, `cashapp-paging-compose-common`). - Updated `TopicRepository` with `getTopicsPage` function to support paged fetching. - Updated previews to reflect the new paged data structure.
Key changes: - Added `TopicPagingSource` to handle fetching paged data. - Modified `TopicViewModel` to use `Pager` for fetching and managing paged data. - Updated `TopicList` and `TopicScreenUI` to consume `LazyPagingItems`. - Added new dependencies for multiplatform paging (`cashapp-paging-common`, `cashapp-paging-compose-common`). - Updated `TopicRepository` with `getTopicsPage` function to support paged fetching. - Updated previews to reflect the new paged data structure.
RajashekarRaju
requested changes
Jul 12, 2025
…ving the intermediate `UiState` and `fetchTopicList` logic. - Modify `TopicRepository.getTopicsPage` to return `List<TopicUi>`. - Make `TopicRepository.getTopics` private as it's now an internal detail. - Update UI components (`TopicList`, `TopicCard`, `TopicScreenUI`) and preview utils to reflect these changes. - Adjust `TopicPagingSource` to work with `TopicUi`. - Rename `ItemTopic` to `TopicUi` and move it to a separate file.
...onMain/kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicUi.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicScreenUI.kt
Outdated
Show resolved
Hide resolved
...lin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicPagingSource.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicViewModel.kt
Outdated
Show resolved
Hide resolved
...lin/com/developersbreach/kotlindictionarymultiplatform/ui/screens/topic/TopicPagingSource.kt
Show resolved
Hide resolved
- Move `TopicPagingSource` to the data layer. - Update `TopicViewModel`, `TopicList`, `TopicCard`, and `TopicScreen` to use the new `Topic` data class. - Adjust `TopicRepository` to return `Topic` objects. - Enhance `TopicPagingSource`'s `getRefreshKey` logic. - Update `PreviewUtils` to use the renamed `Topic` class. - Remove unused Android Paging dependency.
There was a problem hiding this comment.
Review my commit, do you believe this is what you needed?
24f240e
Reviewed. |
RajashekarRaju
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.