fix(server): send TLS close_notify during graceful RDP disconnect #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
November 17, 2025 12:17
Head branch was pushed to by a user without write access
ymarcus93
force-pushed
the
fix-server
branch
from
f4d9b82 to
511674e
Compare
CBenoit
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for sending a proper TLS close_notify message when the RDP client initiates a graceful disconnect PDU.
I've modified
accept_finalizeto return the underlyingTokioFramed<S>once the loop exits onRunState::Disconnect. Then in the case that the connection has been upgraded to TLS, I callshutdown()of the underlying stream which should gracefully close the TLS connection and send the close_notify message.