fix(dvc)!: add channel_id parameter to DvcChannelListener::create#1358
Merged
Conversation
Add `channel_id` args in `DynamicChannelListener` trait's create method Signed-off-by: uchouT <i@uchout.moe>
There was a problem hiding this comment.
Pull request overview
This PR updates the dynamic virtual channel (DVC) client listener interface in ironrdp-dvc to pass the channel_id (from the incoming DYNVC_CREATE_REQ) into the listener’s create method, enabling listeners (e.g., upcoming UrbdrcListener) to differentiate/control per-instance behavior based on the negotiated dynamic channel ID.
Changes:
- Add
channel_id: DynamicChannelIdparameter toDvcChannelListener::create. - Update the built-in
OnceListenerimplementation to accept the new parameter. - Thread
channel_idthroughDynamicChannelSet::try_create_channelwhen invoking the listener.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benoît Cortier (CBenoit)
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
channel_idargs inDynamicChannelListenertrait's create method.channel_idis required when implementingUrbdrcListenerin #1137