Skip to content

fix(dvc)!: add channel_id parameter to DvcChannelListener::create#1358

Merged
Benoît Cortier (CBenoit) merged 1 commit into
Devolutions:masterfrom
uchouT:dvc
Jun 2, 2026
Merged

fix(dvc)!: add channel_id parameter to DvcChannelListener::create#1358
Benoît Cortier (CBenoit) merged 1 commit into
Devolutions:masterfrom
uchouT:dvc

Conversation

@uchouT
Copy link
Copy Markdown
Contributor

Add channel_id args in DynamicChannelListener trait's create method.

channel_id is required when implementing UrbdrcListener in #1137

Add `channel_id` args in `DynamicChannelListener` trait's create method

Signed-off-by: uchouT <i@uchout.moe>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dynamic virtual channel (DVC) client listener interface in ironrdp-dvc to pass the channel_id (from the incoming DYNVC_CREATE_REQ) into the listener’s create method, enabling listeners (e.g., upcoming UrbdrcListener) to differentiate/control per-instance behavior based on the negotiated dynamic channel ID.

Changes:

  • Add channel_id: DynamicChannelId parameter to DvcChannelListener::create.
  • Update the built-in OnceListener implementation to accept the new parameter.
  • Thread channel_id through DynamicChannelSet::try_create_channel when invoking the listener.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CBenoit Benoît Cortier (CBenoit) changed the title refactor(dvc)!: modify Listener trait method args fix(dvc)!: add channel_id parameter to DvcChannelListener::create Jun 2, 2026
@CBenoit Benoît Cortier (CBenoit) enabled auto-merge (squash) June 2, 2026 11:40
Copy link
Copy Markdown
Member

@CBenoit Benoît Cortier (CBenoit) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I changed the commit from refactor! to fix! because if it’s not just changing an implementation detail, it’s changing the public API, and that is something consumers need to care about 🙂

@CBenoit Benoît Cortier (CBenoit) merged commit f21470c into Devolutions:master Jun 2, 2026
21 checks passed
@uchouT uchouT (uchouT) deleted the dvc branch June 2, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants