Skip to content

Conversation

@CBenoit
Copy link
Member

@CBenoit CBenoit commented Nov 9, 2023

Stole the format from rust-analyzer document:

It includes IronRDP-specific guidelines I wrote down during code reviews, as well as some guidelines directly copied from the original rust-analyzer document because they were relevant for IronRDP as well.

Rendered.

@CBenoit CBenoit requested a review from pacmancoder November 9, 2023 20:30
@CBenoit CBenoit enabled auto-merge (squash) November 9, 2023 20:30
@CBenoit CBenoit force-pushed the docs/style.md branch 2 times, most recently from 37901d7 to 3c6590a Compare November 9, 2023 20:35
@github-actions
Copy link

github-actions bot commented Nov 9, 2023

Coverage Report 🤖 ⚙️

Past:
Total lines: 25828
Covered lines: 16187 (62.67%)

New:
Total lines: 25828
Covered lines: 16187 (62.67%)

Diff: +0.00%

[this comment will be updated automatically]

@CBenoit CBenoit force-pushed the docs/style.md branch 7 times, most recently from cb55a56 to 326ca24 Compare November 10, 2023 00:12
Stole the format from rust-analyzer document:
- https://github.com/rust-lang/rust-analyzer/blob/76633199f4316b9c659d4ec0c102774d693cd940/docs/dev/style.md

It includes IronRDP-specific guidelines I wrote down during code reviews,
as well as some guidelines directly copied from the original
rust-analyzer document because they were relevant for IronRDP as well.
Copy link
Contributor

@pacmancoder pacmancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very clean and easy-to-understand code style guide 👍

@CBenoit CBenoit merged commit a5845f5 into master Nov 13, 2023
@CBenoit CBenoit deleted the docs/style.md branch November 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants