Skip to content

Conversation

@dion-gionet
Copy link
Contributor

Also upgraded the SDK and regenerated the chart and revamped the release workflow

@dion-gionet dion-gionet self-assigned this Oct 17, 2025
@dion-gionet dion-gionet requested a review from a team as a code owner October 17, 2025 20:58
@rbstp rbstp requested a review from Copilot October 20, 2025 13:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the missing vaultId field to the DvlsSecret CRD specification and updates the project dependencies and tooling to their latest versions.

Key changes:

  • Added vaultId as a required field in the DvlsSecret CRD schema
  • Upgraded Go to 1.24.0 and updated Kubernetes dependencies to v0.34.1
  • Consolidated the release workflow to trigger manually and include container building

Reviewed Changes

Copilot reviewed 18 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Updated Go version to 1.24.0 and upgraded all dependencies including Kubernetes libraries to v0.34.1
chart/templates/dvlssecret-crd.yaml Added vaultId field as a required property in the CRD spec
config/crd/bases/dvls.devolutions.com_dvlssecrets.yaml Added vaultId field as a required property in the base CRD definition
chart/values.yaml Added security contexts, args, and service account configuration with updated default values
chart/templates/deployment.yaml Refactored to reference values from chart configuration instead of hardcoded values
chart/templates/serviceaccount.yaml New file defining the ServiceAccount resource template
.github/workflows/release.yml Enhanced to build and push Docker images as part of the release process
.github/workflows/build-container.yml Removed standalone container build workflow (consolidated into release.yml)
Dockerfile Updated base image to golang:1.24
Makefile Updated VERSION to 0.2.1 and CONTROLLER_TOOLS_VERSION to v0.16.5
chart/Chart.yaml Bumped chart and app versions to 0.2.1
config/manager/kustomization.yaml Updated image tag from 'latest' to '0.2.1'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Also upgraded the SDK and regenerated the chart and revamped the release workflow
@dion-gionet dion-gionet merged commit f897f26 into master Oct 20, 2025
@dion-gionet dion-gionet deleted the missingvaultid branch October 20, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants