Skip to content

Conversation

@dion-gionet
Copy link
Contributor

@dion-gionet dion-gionet requested a review from a team October 23, 2025 20:10
@dion-gionet dion-gionet self-assigned this Oct 23, 2025
@rbstp rbstp requested a review from Copilot October 24, 2025 13:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom CA certificates to enable the operator to connect to DVLS servers with self-signed certificates. Additionally, it extends credential type support beyond username/password to include access codes, API keys, Azure service principals, connection strings, and private keys.

Key changes:

  • Added CA certificate mounting capability in Helm chart and deployment configuration
  • Removed credential type restrictions and implemented support for multiple credential entry types
  • Updated documentation with CA certificate configuration examples

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
hack/add-ca-cert-to-helm.sh Bash script to inject CA cert volume mounts into Helm deployment template
controllers/dvlssecret_controller.go Removed credential type restrictions and refactored secret mapping to support multiple credential types
config/manager/kustomization.yaml Version bump to 0.3.0
chart/values.yaml Version bump to 0.3.0
chart/templates/deployment.yaml Added conditional SSL_CERT_FILE environment variable and volume mounts for CA certificate
chart/templates/ca-cert-secret.yaml New template for creating CA certificate secret
chart/Chart.yaml Version bump to 0.3.0
README.md Expanded documentation with CA certificate configuration guide and updated credential type descriptions
Makefile Version bump to 0.3.0 and added CA cert injection script to helm build process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dion-gionet dion-gionet merged commit 5cee13e into master Oct 24, 2025
@dion-gionet dion-gionet deleted the devops/selfsigned branch October 24, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Operator doesn't support HTTPS request to a DVLS instance using a self-signed certificate.

2 participants