revert: implement Default for SmartCardType
#534
Merged
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It actually does not make sense to implement Default for SmartCardType. A user-provided PIN must be set. Release 0.18.2 was yanked. Refs: 3555b37
Member
Author
|
cc @allan2, please review this: #532 (comment) |
allan2
approved these changes
Nov 7, 2025
Contributor
allan2
left a comment
allan2
left a comment
There was a problem hiding this comment.
Since the PIN is available, it makes sense to remove Default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It actually does not make sense to implement Default for SmartCardType. A user-provided PIN must be set.
Release 0.18.2 was yanked.
Refs: 3555b37