Skip to content

Conversation

@T-Nicholls
Copy link
Collaborator

@T-Nicholls T-Nicholls commented Jul 25, 2025

Corresponding change for DiamondLightSource/pytac#144, so tests will fail until that is merged

@T-Nicholls T-Nicholls requested review from MJGaughran and ptsOSL July 25, 2025 13:45
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.73%. Comparing base (18acf16) to head (85714f1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   89.28%   86.73%   -2.56%     
==========================================
  Files           6        6              
  Lines         392      392              
==========================================
- Hits          350      340      -10     
- Misses         42       52      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ptsOSL ptsOSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these changes and now:

  • All ATIP tests pass
  • The virtac launches in I04 okay

@T-Nicholls T-Nicholls merged commit fd7efba into DiamondLightSource:main Sep 11, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants