Refactor API posts to send more information on failed posts #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 33.57% 33.58%
=======================================
Files 92 92
Lines 11256 11176 -80
Branches 1474 1469 -5
=======================================
- Hits 3779 3753 -26
+ Misses 7350 7296 -54
Partials 127 127 🚀 New features to boost your workflow:
|
d-j-hatton
approved these changes
Sep 3, 2025
stephen-riggs
added a commit
that referenced
this pull request
Sep 3, 2025
Updates the cli tool used for reposting failed calls, so that it works by calling functions directly. Also updates the router spec and changes the tool for generating that to add session_id where needed. Problems seemed to occur for the two instances where the argument type is Union, which may need fixing in future. Needs to be merged after #651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
capture_post/get/deletecalls to take in the router name and function instead of a url. The url is then constructed.By doing this any failed calls can send the function name on for reuse.