FIX: Error message reports wrong argument number #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RE: > Connect function argument DianaSuvorova#1 should be named mapDispatchToProps I found this error message misleading since normally one does not refer to argument numbers as though they were zero-indexed. So I've just fixed the off-by-one error in the report function.
|
@derrickbeining , thanks for the PR. I see why starting from 0 might be confusing. I remember having the same dilemma when I was writing the code. If you think it will be less confusing to start at 1, I would gladly accept a PR although you would need to fix test failures first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE:
I found this error message misleading since normally one does not refer to argument numbers as though they were zero-indexed. So I've just fixed the off-by-one error in the report function.