`GET.WATCH` Notified Unexpectedly on GET Operation

[irounik]

Steps to Reproduce

Open two terminals (T1 & T2)
T2:
GET.WATCH key1

T1:
SET key1 value1
GET key1

Expected output

T2 should get the "value1" for key "key1" only once.

T2:

localhost:7379> GET.WATCH key1
entered the watch mode for GET.WATCH key1
OK [fingerprint=765825083] value1

Observed output

T2 got "value1" twice. This is the first time for SET and the second for a GET command.

T2:

localhost:7379> GET.WATCH key1
entered the watch mode for GET.WATCH key1
OK [fingerprint=765825083] value1
OK [fingerprint=765825083] value1 // Got value for the second time when GET was called on T1

[SValanukonda]

hi @irounik and @arpitbbhayani what to add one more observation , even if set command fails , we are notifying watch clients

#

[SValanukonda]

hi @arpitbbhayani , fix is addressed in this PR #1688

[SValanukonda]

hi @arpitbbhayani , I've raised a new PR #1739 and resolved the merge conflicts. Please review the latest changes.