This repository was archived by the owner on Jun 23, 2025. It is now read-only.
Fix dice exit process on GET.WATCH with no arg.
#1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
apoorvyadav1111
approved these changes
Mar 21, 2025
Contributor
apoorvyadav1111
left a comment
apoorvyadav1111
left a comment
There was a problem hiding this comment.
Thanks for this update.
apoorvyadav1111
suggested changes
Mar 21, 2025
Contributor
apoorvyadav1111
left a comment
apoorvyadav1111
left a comment
There was a problem hiding this comment.
I think adding a test case for validating this behavior will prevent this in future.
Thank You.
pratik-pc
force-pushed
the
issue-getwatch-no-arg
branch
from
f5e2a6f to
fe8dfc2
Compare
Contributor
Author
|
Added test for this |
Contributor
|
Thanks for the patch! |
Dev79844
pushed a commit
to Dev79844/dice
that referenced
this pull request
Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1595