Fix/doris 2540 subtitle padding #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoen21
requested changes
Nov 12, 2024
guoen21
previously approved these changes
Nov 12, 2024
NormanWangEndeavor
previously approved these changes
Nov 12, 2024
szaboa
reviewed
Nov 14, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 14, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 14, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
WeiLiuSH
dismissed stale reviews from NormanWangEndeavor and guoen21
via
46dda34
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/SubtitlePainter.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/PaddingLineBackgroundSpan.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/PaddingLineBackgroundSpan.java
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
libraries/ui/src/main/java/androidx/media3/ui/PaddingLineBackgroundSpan.java
Outdated
Show resolved
Hide resolved
szaboa
reviewed
Nov 25, 2024
demos/main/src/main/java/androidx/media3/demo/main/PlayerActivity.java
Outdated
Show resolved
Hide resolved
szaboa
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: Doris-2540
add padding for subtitle
ScreenShot:
