Skip to content

Fix/preroll flash when resume vod #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guoen21 merged 2 commits into from
Aug 12, 2025
Merged

Fix/preroll flash when resume vod #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c314c4
chore: add isPlaybackPrepared to fix preroll flashes issue when resum…
guoen21 Aug 8, 2025
a0f648b
chore: fix review comments
guoen21 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions constants.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.
project.ext {
releaseVersion = '1.4.1-dr5'
releaseVersionCode = 1_004_001_5_00
releaseVersion = '1.4.1-dr6'
releaseVersionCode = 1_004_001_6_00
minSdkVersion = 19
// See https://developer.android.com/training/cars/media/automotive-os#automotive-module
automotiveMinSdkVersion = 28
Expand Down
23 changes: 23 additions & 0 deletions libraries/ui/src/main/java/androidx/media3/ui/PlayerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ public interface FullscreenButtonClickListener {
private boolean controllerHideOnTouch;
private int textureViewRotation;

/** Indicates if the playback media is currently prepared. */
private boolean isPlaybackPrepared = true;

public PlayerView(Context context) {
this(context, /* attrs= */ null);
}
Expand Down Expand Up @@ -1308,6 +1311,20 @@ public void setLimitedSeekRange(LimitedSeekRange limitedSeekRange) {
}
}

/**
* Sets whether the the playback media is currently prepared.
*
* @param prepared Indicates if the playback media is currently prepared.
*/
public void setPlaybackPrepared(boolean prepared) {
if (prepared && !isPlaybackPrepared) {
mainLooperHandler.postDelayed(() -> isPlaybackPrepared = true, 200L);
componentListener.hideShutterView();
} else if (!prepared && isPlaybackPrepared) {
isPlaybackPrepared = false;
}
}

/**
* Sets the {@link AspectRatioFrameLayout.AspectRatioListener}.
*
Expand Down Expand Up @@ -1904,6 +1921,12 @@ public void onSurfaceSizeChanged(int width, int height) {

@Override
public void onRenderedFirstFrame() {
if (isPlaybackPrepared) {
hideShutterView();
}
}

private void hideShutterView() {
if (shutterView != null) {
shutterView.setVisibility(INVISIBLE);
if (hasSelectedImageTrack()) {
Expand Down