merging fork #2
Merged
merging fork #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not short lived
…createStoredProcedureQuery
…y when forcing the JDBC timezone
…resenting an instant at DST end in the default JVM timezone Note problems can still occur in the JDBC driver if the JDBC timezone is not forced to GMT/UTC.
…eviously existing alias definition
… to a Set if @PreUpdate listener exists
…tements for a batch
…, Statement statement) from AbstractLoadPlanBasedLoader#executeLoad()
…ringHelper#unquote(String[], Dialect) if there are no changes to be applied
in mapping superclass that makes use of generics.
…in common scenario
…oxy with immutable natural ID
…th entity and query results
…yImplementor argument instead of PersisterCreationContext
…yImplementor argument instead of PersisterCreationContext
ConnectorJ 8 is the version used in WildFly integration tests. ConnectorJ 5 is apparently no longer tested. Note this solves most timezone-related issues we've been having.
MySQL ConnectorJ 8.x returns the wrong date when the JVM default timezone is different from the server timezone: https://bugs.mysql.com/bug.php?id=91112
…TypeTest We were testing GMT instead of UTC-8 without even knowing it...
…ead' test for MySQL The returned time is right (otherwise #writeThenRead would fail), it's just that a different day is returned, but it won't affect the LocalTime representation manipulated by the user.
…t#getTime(int, Calendar) method
…adb task It's already the version we use when running test -Pdb=mariadb, so let's be consistent.
…-generation.scripts.action in hibernate.properties
It's already the version we use when running test -Pdb=hana, so let's be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.