Skip to content

Support parsing of <center> element for ways (XML only) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 21, 2016
Merged

Support parsing of <center> element for ways (XML only) #47

merged 8 commits into from
Nov 21, 2016

Conversation

@phibos
Copy link
Member

@phibos phibos commented Nov 21, 2016

Issue type
  • Feature
Summary

You can find the original pull request at #27. I have create a new pull request to merge it with the latest master branch.

Original description.

The 'out center' Overpass QL option provides a centroid for each way in a element. I've added support for parsing the element, but N.B. only for ways (not relations) and only for XML (not JSON).

I've also corrected a mistake in the 'Unknown element end' KeyError message.

@phibos phibos added this to the 0.4 milestone Nov 21, 2016
@phibos phibos self-assigned this Nov 21, 2016
@coveralls
Copy link

coveralls commented Nov 21, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 94.176% when pulling ef2a159 on gregrs-uk-way-center into bebe253 on master.

2 similar comments
@coveralls
Copy link

coveralls commented Nov 21, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 94.176% when pulling ef2a159 on gregrs-uk-way-center into bebe253 on master.

@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage decreased (-0.03%) to 94.176% when pulling ef2a159 on gregrs-uk-way-center into bebe253 on master.

@phibos phibos changed the title [WiP] Support parsing of <center> element for ways (XML only) Support parsing of <center> element for ways (XML only) Nov 21, 2016
@phibos phibos merged commit 2961bb9 into master Nov 21, 2016
This was referenced Nov 21, 2016
Merged
Closed
@phibos phibos deleted the gregrs-uk-way-center branch November 27, 2016 21:19
@gregrs-uk gregrs-uk mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@phibos phibos

Labels

enhancement

Projects

None yet

Milestone

0.4

Development

Successfully merging this pull request may close these issues.

4 participants

@phibos @coveralls @gregrs-uk