Improve multithreading and remove deprecated ffi.verify() #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructuring the source to remove ffi.verify() - Some options are still hard coded
Member
Author
|
At the moment ci builds will fail because the setup.py and the build process have to be modified to work with the new structure. To test the current state, you can run the following commands in the root of the repo pytest is already running without errors. |
Closed
- Add initial pyproject.toml - Update tox.ini to use isolated builds
- Add requirement for sphinx>=1.2 - Remove mock module
Member
Author
|
All checks have passed. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
With version 3.4 a warning is shown if used with the threading package. Also the ffi.verify() function has been deprecated with cffi >= 1.0
This pull request fixes #50