Skip to content

Replace Carbon types with CarbonInterface to support CarbonImmutable #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Replace Carbon types with CarbonInterface to support CarbonImmutable #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6c60fb
Refactor lastReceivedAt type to support CarbonImmutable
abdelhamiderrahmouni Oct 7, 2025
d1e395b
Use CarbonInterface
stevebauman Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Commands/HandleMessageReceived.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace DirectoryTree\ImapEngine\Laravel\Commands;

use Carbon\CarbonInterface;
use DirectoryTree\ImapEngine\Laravel\Events\MessageReceived;
use DirectoryTree\ImapEngine\MessageInterface;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Date;
use Illuminate\Support\Facades\Event;

Expand All @@ -16,7 +16,7 @@ class HandleMessageReceived
public function __construct(
protected WatchMailbox $command,
protected int &$attempts = 0,
protected ?Carbon &$lastReceivedAt = null,
protected ?CarbonInterface &$lastReceivedAt = null,
) {}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/Events/MailboxWatchAttemptsExceeded.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace DirectoryTree\ImapEngine\Laravel\Events;

use Carbon\Carbon;
use Carbon\CarbonInterface;
use Exception;

class MailboxWatchAttemptsExceeded
Expand All @@ -14,6 +14,6 @@ public function __construct(
public string $mailbox,
public int $attempts,
public Exception $exception,
public ?Carbon $lastReceivedAt = null,
public ?CarbonInterface $lastReceivedAt = null,
) {}
}