Skip to content

Conversation

@OseSem
Copy link
Contributor

@OseSem OseSem commented Mar 10, 2024

Description

In intro.mdx it said inpired by discord.js instead of inspired by discord.js`

I also added a small note in CONTRIBUTING.md for people that tells them to make an issue before making a PR so they don't make something you guys don't want to include.

Just a small commit but anything helps right ;)

@OseSem
Copy link
Contributor Author

OseSem commented Mar 14, 2024

@shiftinv could you look at this some time? Aswell as my issue about Classes.

@OseSem OseSem changed the title intro.mdx inpired -> inspired Small Changes in Contributing / Grammar Mar 14, 2024
@shiftinv
Copy link
Member

@shiftinv could you look at this some time? Aswell as my issue about Classes.

It has unfortunately been a rather busy week :/
Other than the one comment just now, this looks good to me.
I'll get to the other issue tomorrow, still need some time to think about it and discuss with others.

@OseSem
Copy link
Contributor Author

OseSem commented Mar 14, 2024

@shiftinv could you look at this some time? Aswell as my issue about Classes.

It has unfortunately been a rather busy week :/

Other than the one comment just now, this looks good to me.

I'll get to the other issue tomorrow, still need some time to think about it and discuss with others.

Alright, thanks for responding

Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Sem <91069296+OseSem@users.noreply.github.com>
@OseSem
Copy link
Contributor Author

OseSem commented Mar 15, 2024

I fixed your comment about grammar.

Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv merged commit 0248240 into DisnakeDev:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants