Skip to content

Conversation

@nahuelhds
Copy link
Contributor

@nahuelhds nahuelhds commented May 25, 2020

Now the database connection is handled with the db property directly and using URL database connections. If no db prop is defined, the value sqlite:///diffengine.db is used in order to maintain compatibility.

In order for this to work with PostgreSQL I've added psycopg2-binary==2.8.5 package. So, basically, with this feature the project has "native" support for Sqlite and PostgreSql. If any other engine is desired, then the proper package needs to be installed (MySQL or any other) and of course the proper database url string to be set as indicated in the peewee docs

The postgre configuration requires using ?autorollback=true at the end of the database url, in order to avoiding unwanted errors These ones were because of the emailed column that my schema was missing after the changes in #77.

I've updated the chromedriver in Travis CI in the PR #84 and I've cherry picked those commits for the CI to pass here too.

Non related

@nahuelhds nahuelhds marked this pull request as draft May 25, 2020 23:45
@nahuelhds nahuelhds force-pushed the feature/configurable-database branch from 46d8bbd to 7f168c8 Compare May 26, 2020 00:55
@nahuelhds nahuelhds marked this pull request as ready for review May 26, 2020 01:34
@nahuelhds nahuelhds closed this Jun 2, 2020
@nahuelhds nahuelhds deleted the feature/configurable-database branch June 2, 2020 23:25
@nahuelhds nahuelhds restored the feature/configurable-database branch June 3, 2020 00:03
@nahuelhds nahuelhds reopened this Jun 3, 2020
@nahuelhds
Copy link
Contributor Author

@edsu this one is ready to be merged too!

@edsu edsu merged commit 60f4270 into DocNow:master Jun 3, 2020
@nahuelhds nahuelhds deleted the feature/configurable-database branch June 3, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make time.sleep configurable and default to zero

2 participants