Composer libraries requirements update for PHP >=8.0 support. resolves #18 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szhajdu
reviewed
Mar 4, 2022
composer.json
Outdated
| "codeception/codeception": "^4.0", | ||
| "codeception/lib-innerbrowser": "^1.0", | ||
| "codeception/lib-innerbrowser": "^2.0", | ||
| "slim/psr7": "^1.1", |
Collaborator
There was a problem hiding this comment.
Please also set to ^1.3. PHP 8 support came with that version.
szhajdu
reviewed
Mar 4, 2022
composer.json
Outdated
| "codeception/lib-innerbrowser": "^1.0", | ||
| "codeception/lib-innerbrowser": "^2.0", | ||
| "slim/psr7": "^1.1", | ||
| "slim/slim": "^4.2" |
Collaborator
There was a problem hiding this comment.
Please set to ^4.7 as well.
szhajdu
requested changes
Mar 4, 2022
Collaborator
szhajdu
left a comment
szhajdu
left a comment
There was a problem hiding this comment.
Thank you for your contribution, please check my comments.
Contributor
Author
|
Made requested chages (in 5a2e0ea), should be ok now. You can check it out. Thanks. |
Contributor
Author
|
Just info, that new commit 8d2d586 has fixed github static analysis actions and its php8 requirement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped PHP 7 support.