Skip to content

Conversation

@rfgamaral
Copy link
Member

@rfgamaral rfgamaral commented Aug 28, 2024

Short description

This PR adds the xsmall size to the Modal component, and changes the small value from 450px to 480px so that the new Information/Confirmation modals can be stacked on top of other modals like this:

image

PR Checklist

  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Minor

@rfgamaral rfgamaral self-assigned this Aug 28, 2024
@rfgamaral rfgamaral requested review from a team, nats12 and scottlovegrove and removed request for a team and nats12 August 28, 2024 21:07
@rfgamaral
Copy link
Member Author

Re-rolling because Natalie is out today.

@rfgamaral rfgamaral merged commit e194265 into main Aug 29, 2024
@rfgamaral rfgamaral deleted the ricardo/review-modal-widths branch August 29, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants