Skip to content

Conversation

@pedroalves0
Copy link
Member

Short description

The Banner component system types icons had their colors hardcoded. In this PR we are changing that so that they can be customized through CSS variables. The default colors are the same as the ones previously harcoded.

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Minor -> 27.1.0

@pedroalves0 pedroalves0 self-assigned this Jan 13, 2025
@pedroalves0 pedroalves0 merged commit d88972b into main Jan 13, 2025
5 checks passed
@pedroalves0 pedroalves0 deleted the pedroa/banner-colors branch January 13, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants