-
Notifications
You must be signed in to change notification settings - Fork 24
build: Update TypeScript to 5.9 #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3b9751 to
5da4cb8
Compare
5da4cb8 to
6b53e57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors import statements across the codebase to separate type imports from value imports using TypeScript's import type syntax, and updates several package versions including TypeScript (4.8.3 → 5.9.3), @storybook/react (^6.5.3 → 6.5.17-alpha.0), and @doist/tsconfig (^1.0.0 → 2.0.0).
Key changes:
- Systematically separates type imports from value imports using
import typesyntax - Updates TypeScript to version 5.9.3
- Updates Storybook React to alpha version 6.5.17-alpha.0
- Adds fork-ts-checker-webpack-plugin 6.5.3 as an explicit dependency
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates TypeScript to 5.9.3, Storybook to 6.5.17-alpha.0, adds fork-ts-checker-webpack-plugin, updates @doist/tsconfig to 2.0.0 |
| package-lock.json | Reflects package.json dependency updates with resolved versions |
| src//*.tsx, src//*.ts | Separates type imports using import type syntax across all TypeScript/TSX files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6b53e57 to
28eb8f2
Compare
Short description
As titled. This is a pre-requisite to updating Ariakit.
Reference: ariakit/ariakit#3733
We also have to update to the last 6.x version of Storybook for compatibiltiy with TypeScript 5.0: storybookjs/storybook#21745
Test plan