Skip to content

Conversation

@frankieyan
Copy link
Member

@frankieyan frankieyan commented Nov 1, 2025

Short description

As titled. This is a pre-requisite to updating Ariakit.

Reference: ariakit/ariakit#3733

We also have to update to the last 6.x version of Storybook for compatibiltiy with TypeScript 5.0: storybookjs/storybook#21745

Test plan

  • Quick smoke test in Storybook

@frankieyan frankieyan force-pushed the frankie/update-typescript branch from b3b9751 to 5da4cb8 Compare November 1, 2025 07:13
@frankieyan frankieyan added 🙋 Ask PR Used for PRs that need a review before merging. 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. and removed 🙋 Ask PR Used for PRs that need a review before merging. labels Nov 1, 2025
@frankieyan frankieyan requested review from a team and pedroalves0 and removed request for a team November 1, 2025 07:40
@frankieyan frankieyan changed the base branch from frankie/update-eslint-dependencies to frankie/update-eslint-dependencies-2 November 2, 2025 03:11
@frankieyan frankieyan force-pushed the frankie/update-typescript branch from 5da4cb8 to 6b53e57 Compare November 2, 2025 03:11
@frankieyan frankieyan requested a review from Copilot November 2, 2025 03:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors import statements across the codebase to separate type imports from value imports using TypeScript's import type syntax, and updates several package versions including TypeScript (4.8.3 → 5.9.3), @storybook/react (^6.5.3 → 6.5.17-alpha.0), and @doist/tsconfig (^1.0.0 → 2.0.0).

Key changes:

  • Systematically separates type imports from value imports using import type syntax
  • Updates TypeScript to version 5.9.3
  • Updates Storybook React to alpha version 6.5.17-alpha.0
  • Adds fork-ts-checker-webpack-plugin 6.5.3 as an explicit dependency

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

File Description
package.json Updates TypeScript to 5.9.3, Storybook to 6.5.17-alpha.0, adds fork-ts-checker-webpack-plugin, updates @doist/tsconfig to 2.0.0
package-lock.json Reflects package.json dependency updates with resolved versions
src//*.tsx, src//*.ts Separates type imports using import type syntax across all TypeScript/TSX files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@frankieyan frankieyan changed the title chore: Update TypeScript to 5.9 build: Update TypeScript to 5.9 Nov 4, 2025
Base automatically changed from frankie/update-eslint-dependencies-2 to main November 4, 2025 22:26
@frankieyan frankieyan force-pushed the frankie/update-typescript branch from 6b53e57 to 28eb8f2 Compare November 4, 2025 22:28
@frankieyan frankieyan enabled auto-merge (squash) November 4, 2025 22:29
@frankieyan frankieyan merged commit 389931a into main Nov 4, 2025
5 of 6 checks passed
@frankieyan frankieyan deleted the frankie/update-typescript branch November 4, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR Used for PRs that need a review, but can be merged when CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants