feat!: Update Ariakit to 0.4.19 #981
Conversation
frankieyan
added
the
👀 Show PR
frankieyan
changed the title
frankieyan
requested review from
a team and
rmartins90
and removed request for
a team
frankieyan
force-pushed
the
frankie/update-typescript
branch
from
5da4cb8 to
6b53e57
Compare
frankieyan
force-pushed
the
frankie/update-ariakit-0.4.19
branch
from
718e0f3 to
c858bec
Compare
| userEvent.click(screen.getByRole('tab', { name: 'Tab 2' })) | ||
| expect(screen.getByText('Content of tab 1')).not.toBeVisible() | ||
|
|
||
| await waitFor(() => { |
There was a problem hiding this comment.
Just curious, why these changes in tests?
There was a problem hiding this comment.
These were failing without this, possibly due to Ariakit queueing these behind additional microtasks compared to the previous version. The same thing happens in Todoist - similar changes needed to be added there after pulling this in.
|
@frankieyan why are we marking this RP as containing breaking change in the PR title? |
|
@rmartins90 while Ariakit's changelog doesn't mention any breaking changes in the range we're upgrading to, I marked this as breaking as it requires updates to our tests. I'm also moving it to a peer dependency so that consumers will need to explicitly list it as a dependency (as we already do), so for us, I don't think it makes sense for Renovate to pick this up automatically. With the loosened restrictions (with the tilde symbol), consumers can technically use any patch updates beyond 0.4.19 so we are no longer blocking Ariakit updates with Reactist in the future. Do you think it should be a patch/minor update instead? |
frankieyan
changed the title
frankieyan
force-pushed
the
frankie/update-typescript
branch
from
6b53e57 to
28eb8f2
Compare
frankieyan
force-pushed
the
frankie/update-ariakit-0.4.19
branch
from
e1cbd09 to
b17ce4a
Compare
frankieyan
changed the title
you mean on consumer side, right? |
Yup 👍 Also turns out, there was a small breaking change in Ariakit 0.4.9 as well: https://ariakit.org/changelog#aria-selected-on-composite-items |
Short description
This PR updates Ariakit to the latest available version.
Changelogs: https://ariakit.org/changelog
Test plan
yalcto pull this into Todoist'sfrankie/ariakit-0.4.19branch and verify that the app builds