Skip to content

feat!: Update Ariakit to 0.4.19 #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

feat!: Update Ariakit to 0.4.19 #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3eef8c9
chore: Update Ariakit to 0.4.19
frankieyan Nov 1, 2025
79f7a93
Wait for tabs to be visible in tests
frankieyan Nov 1, 2025
b17ce4a
Loosen Ariakit peer dependency version
frankieyan Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,14 @@
"plop": "plop"
},
"peerDependencies": {
"@ariakit/react": "~0.4.19",
"classnames": "^2.2.5",
"prop-types": "^15.6.2",
"react": "^17.0.0 || ^18.0.0",
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@ariakit/react": "0.4.19",
"@babel/core": "^7.9.6",
"@babel/plugin-proposal-class-properties": "^7.10.1",
"@babel/plugin-proposal-export-default-from": "^7.0.0",
Expand Down Expand Up @@ -161,7 +163,6 @@
"webpack": "^4.43.0"
},
"dependencies": {
"@ariakit/react": "0.4.5",
"aria-hidden": "^1.2.1",
"dayjs": "^1.8.10",
"patch-package": "^6.4.6",
Expand Down
33 changes: 26 additions & 7 deletions src/tabs/tabs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,24 @@ describe('Tabs', () => {
expect(screen.getByText('Content of tab 3')).not.toBeVisible()

userEvent.click(screen.getByRole('tab', { name: 'Tab 2' }))
expect(screen.getByText('Content of tab 1')).not.toBeVisible()

await waitFor(() => {
Copy link
Contributor

@rmartins90 rmartins90 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why these changes in tests?

Copy link
Member Author

@frankieyan frankieyan Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were failing without this, possibly due to Ariakit queueing these behind additional microtasks compared to the previous version. The same thing happens in Todoist - similar changes needed to be added there after pulling this in.

expect(screen.getByText('Content of tab 1')).not.toBeVisible()
})

expect(screen.getByRole('tabpanel', { name: 'Tab 2' })).toBeVisible()
expect(screen.getByText('Content of tab 2')).toBeVisible()
expect(screen.getByText('Content of tab 3')).not.toBeVisible()

userEvent.click(screen.getByRole('tab', { name: 'Tab 3' }))

await waitFor(() => {
expect(screen.getByText('Content of tab 2')).not.toBeVisible()
})

expect(screen.getByText('Content of tab 1')).not.toBeVisible()
expect(screen.getByText('Content of tab 2')).not.toBeVisible()
expect(screen.getByRole('tabpanel', { name: 'Tab 3' })).toBeVisible()
expect(screen.getByText('Content of tab 3')).toBeVisible()
expect(screen.getByRole('tabpanel', { name: 'Tab 3' })).toBeVisible()
})

it("renders a tab's content only when they're active when each TabPanel's `render` prop is set to 'active'", async () => {
Expand Down Expand Up @@ -103,19 +111,27 @@ describe('Tabs', () => {
expect(screen.queryByText('Content of tab 3')).not.toBeInTheDocument()

userEvent.click(screen.getByRole('tab', { name: 'Tab 2' }))
expect(screen.getByText('Content of tab 1')).not.toBeVisible()

await waitFor(() => {
expect(screen.getByText('Content of tab 1')).not.toBeVisible()
})

expect(screen.getByRole('tabpanel', { name: 'Tab 2' })).toBeVisible()
expect(screen.getByText('Content of tab 2')).toBeVisible()
expect(screen.queryByText('Content of tab 3')).not.toBeInTheDocument()

userEvent.click(screen.getByRole('tab', { name: 'Tab 3' }))

await waitFor(() => {
expect(screen.getByText('Content of tab 2')).not.toBeVisible()
})

expect(screen.getByText('Content of tab 1')).not.toBeVisible()
expect(screen.getByText('Content of tab 2')).not.toBeVisible()
expect(screen.getByRole('tabpanel', { name: 'Tab 3' })).toBeVisible()
expect(screen.getByText('Content of tab 3')).toBeVisible()
})

it('becomes a controlled component when selectedId is provided', () => {
it('becomes a controlled component when selectedId is provided', async () => {
const { rerender } = render(
<Tabs>
<TabList aria-label="test-tabs">
Expand Down Expand Up @@ -149,9 +165,12 @@ describe('Tabs', () => {
</Tabs>,
)

await waitFor(() => {
expect(screen.getByText('Content of tab 2')).not.toBeVisible()
})

expect(onSelectedIdChange).not.toHaveBeenCalled()
expect(screen.getByText('Content of tab 1')).not.toBeVisible()
expect(screen.getByText('Content of tab 2')).not.toBeVisible()
expect(screen.getByText('Content of tab 3')).toBeVisible()

userEvent.click(screen.getByRole('tab', { name: 'Tab 2' }))
Expand Down