Fix admonition syntax and separate custom containers #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongyuZhao
added a commit
that referenced
this pull request
Jul 21, 2025
* Refactor to token based consumer * Implement emphasis parsing (#44) * Update parser to allow flex token consuming * Add Markdown inline parsing features (#45) * Add basic Markdown parsing builders * Improve emphasis parsing * Fix parser loop and add blockquote builder * Fix token parsing and update tests * Add block element support (#46) * Add CommonMark block elements and GFM extensions * Update feature list and roadmap * Remove duplicated roadmap entry * Add definition lists and admonition support * Extract language from fenced code blocks (#47) * Fix test names and update markdown docs (#48) * chore: update test naming and docs * Fix warnings, rename tests directory, add comprehensive builder tests * Extend all-features test with links and autolink * Separate admonitions from custom containers (#49) * Tokenize custom container block (#50) * Update MARKDOWN_PARSER.md * Update MARKDOWN_PARSER.md --------- Co-authored-by: Dongyu Zhao <donz@DONZ-WORK-MBP.local>
DongyuZhao
deleted the
codex/fix-admonitions-implementation-and-documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MarkdownAdmonitionBuilderfor> [!NOTE]style admonitionsMarkdownCustomContainerBuilderMarkdownLanguageTesting
swift testhttps://chatgpt.com/codex/tasks/task_e_687da4b591548322817b3ed260150b5e