Skip to content

fix(chart): allow sa to read metrics #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2023
Merged

fix(chart): allow sa to read metrics #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3933576
fix(chart): allow sa to read metrics
raffis Jun 12, 2023
10b8713
style: fix values lint
raffis Jun 12, 2023
4a445f4
fix: chart spec
raffis Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/k8sreq-duplicator-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ keywords:
name: k8sreq-duplicator-controller
sources:
- https://github.com/DoodleScheduling/k8sreq-duplicator-controller
version: 0.0.2
version: 0.0.3
2 changes: 1 addition & 1 deletion chart/k8sreq-duplicator-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ spec:
- --upstream=http://127.0.0.1:{{ .Values.metricsPort }}
- --logtostderr=true
- --v=0
image: quay.io/brancz/kube-rbac-proxy:v0.14.0
image: {{ .Values.kubeRBACProxy.image }}
imagePullPolicy: IfNotPresent
name: kube-rbac-proxy
ports:
Expand Down
18 changes: 18 additions & 0 deletions chart/k8sreq-duplicator-controller/templates/metrics-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,24 @@ rules:
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "k8sreq-duplicator-controller.fullname" . }}-metrics
labels:
app.kubernetes.io/name: {{ include "k8sreq-duplicator-controller.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
helm.sh/chart: {{ include "k8sreq-duplicator-controller.chart" . }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: {{ include "k8sreq-duplicator-controller.fullname" . }}-metrics-reader
subjects:
- kind: ServiceAccount
name: {{ template "k8sreq-duplicator-controller.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "k8sreq-duplicator-controller.fullname" . }}-proxy
labels:
Expand Down
5 changes: 3 additions & 2 deletions chart/k8sreq-duplicator-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ securityContext:
drop: ["all"]
readOnlyRootFilesystem: true

podSecurityContext:
podSecurityContext:
runAsGroup: 10000
runAsNonRoot: true
runAsUser: 10000
Expand Down Expand Up @@ -132,6 +132,7 @@ prometheusRule:

kubeRBACProxy:
enabled: true
image: quay.io/brancz/kube-rbac-proxy:v0.14.2
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand All @@ -145,5 +146,5 @@ kubeRBACProxy:
# requests:
# cpu: 5m
# memory: 64Mi

tolerations: []