Last todo fixes

[Feiryn]

No description provided.

[Copilot]

Pull Request Overview

This PR updates the player blocking mechanism by replacing usages of player.id with player.keycloakId, ensuring that all blocking and unblocking functions use the correct player identifier.

• Replaces player.id with player.keycloakId in blocking/unblocking functions across various player, pet, mission, guild, and admin test commands.
• Ensures consistent use of the keycloakId for all operations that manage player state during command execution.

Reviewed Changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Core/src/commands/player/SellCommand.ts	Updated blocking functions to use keycloakId instead of id.
Core/src/commands/player/ReportCommand.ts	Replaced player.id with player.keycloakId in multiple blocking and unblocking calls.
Core/src/commands/player/JoinBoatCommand.ts	Updated blocking calls to use keycloakId.
Core/src/commands/player/DrinkCommand.ts	Modified blocking calls to use keycloakId.
Core/src/commands/player/ClassesCommand.ts	Consistently using keycloakId for blocking/unblocking actions.
Core/src/commands/pet/PetTransferCommand.ts	Updated blocking calls from id to keycloakId.
Core/src/commands/pet/PetSellCommand.ts	Adjusted blocking check and unblocking calls to use keycloakId and re-ordered player registration.
Core/src/commands/pet/PetFreeCommand.ts	Updated to use keycloakId in blocking calls.
Core/src/commands/pet/PetFeedCommand.ts	Replaced id with keycloakId in all blocking calls.
Core/src/commands/mission/MissionShopCommand.ts	Updated blocking calls to use keycloakId.
Core/src/commands/guild/GuildLeaveCommand.ts	Replaced id with keycloakId in unblocking and blocking calls.
Core/src/commands/guild/GuildKickCommand.ts	Updated blocking and unblocking calls to keycloakId.
Core/src/commands/guild/GuildInviteCommand.ts	Modified blocking calls to correctly use keycloakId.
Core/src/commands/guild/GuildElderRemoveCommand.ts	Changed blocking calls to reference keycloakId.
Core/src/commands/guild/GuildElderCommand.ts	Updated blocking calls from id to keycloakId.
Core/src/commands/guild/GuildDescriptionCommand.ts	Replaced id with keycloakId in blocking functions.
Core/src/commands/guild/GuildDailyCommand.ts	Revised blocking-related functionality to use keycloakId.
Core/src/commands/guild/GuildCreateCommand.ts	Updated blocking and unblocking calls to use keycloakId.
Core/src/commands/admin/testCommands/Time/BlockPlayerTestCommand.ts	Changed blocking call to use keycloakId.
Core/src/commands/admin/testCommands/Player/UnblockTestCommand.ts	Updated unblocking call to use keycloakId.

Comments suppressed due to low confidence (2)

Core/src/commands/player/SellCommand.ts:28

• Ensure that player.keycloakId is always defined at this point to prevent potential runtime errors when unblocking a player.

BlockingUtils.unblockPlayer(player.keycloakId, BlockingConstants.REASONS.SELL);

Core/src/commands/pet/PetSellCommand.ts:147

• Review the change in ordering where the blocking check now uses reactingPlayerKeycloakId directly before retrieving the full player record; ensure that this does not bypass necessary context required by appendBlockedPacket.

if (BlockingUtils.appendBlockedPacket(reactingPlayerKeycloakId, response)) {