Skip to content

Conversation

@allenlinli
Copy link
Contributor

@danipralea
Copy link

this is Swift 3 update, right?

@allenlinli
Copy link
Contributor Author

Yes, sorry my commit description isn't so clear.

@danipralea
Copy link

cool, thanks. no worries

@sunshinejr
Copy link
Contributor

Thank you very much @allenlinli! 🎉 I will try to get to this as soon as possible. But at a first glance it looks good! 👏

@allenlinli
Copy link
Contributor Author

Thanks! :D I am happy to help!

pod 'RxSwift', '~> 2.0'
pod 'RxCocoa', '~> 2.0'
pod 'RxOptional', '~> 2.0'
pod 'RxSwift', '~> 3.0.0-beta.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because now RxSwift is officially 3.0.0, can we try with 3.0.0 versions of RxSwift & RxCocoa? :)

@allenlinli
Copy link
Contributor Author

Yes, I will fix it soon!

On Wed, Oct 26, 2016 at 8:54 AM Łukasz Mróz notifications@github.com
wrote:

@sunshinejr commented on this pull request.

In Libraries Usage/RxMoyaExample/Podfile
#3 (review)
:

target 'RxMoyaExample' do

-pod 'Moya/RxSwift'
-pod 'Moya-ModelMapper/RxSwift'
-pod 'RxSwift', '> 2.0'
-pod 'RxCocoa', '
> 2.0'
-pod 'RxOptional', '> 2.0'
+pod 'RxSwift', '
> 3.0.0-beta.2'

Because now RxSwift is officially 3.0.0, can we try with 3.0.0 versions of
RxSwift & RxCocoa? :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAz39wF91AwtNCkYA9BvfIAMRp6BnJ-nks5q3oGkgaJpZM4KbAW6
.

[image: --]

Li Lin
[image: https://]about.me/allenlinli
https://about.me/allenlinli?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links

@sunshinejr
Copy link
Contributor

I will just merge it and start working on the rest, thank you very much for your great work @allenlinli! 🎉🎉🎉

@sunshinejr sunshinejr merged commit ef4c7ba into DroidsOnRoids:master Nov 10, 2016
@allenlinli
Copy link
Contributor Author

Thank you @sunshinejr ! Ha, sorry I was busy these two weeks that I didn't fix them in time.
I am happy I helped such a RxSwift example a tiny little bit :)

@sunshinejr
Copy link
Contributor

No problem! 👊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants