i18n Support and Task improvements #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecDuck
requested changes
Jun 2, 2025
| import { taskGroups, type TaskGroup } from "./group"; | ||
|
|
||
| // a task that has been run | ||
| type FinishedTask = { |
There was a problem hiding this comment.
We should probably keep historic tasks in the database, perhaps with some sort of 'log rotation'?
There was a problem hiding this comment.
Yea, i was probably just gonna create a new task to cleanup logs older then x days
| switch (local) { | ||
| case "en": | ||
| case "en_gb": | ||
| case "en_ca": |
There was a problem hiding this comment.
Can we add Australia and New Zealand (en_au and en_nz), or just match all en_*
There was a problem hiding this comment.
that was mostly just testing on my end, in the future they will just have their own emoji instead of using the US one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53, and lays the groundwork for #52