Add photo editing and video support

[DrunkOnJava]

Summary

• implement Video model and storage/repository
• expose makeVideoRepository in CoreModule
• track videoIds on Item
• allow selecting videos in Add Item flow
• add simple photo editor for crop/rotate

Testing

• make test (fails: Bad substitution)

---

https://chatgpt.com/codex/tasks/task_e_686dd7dbd9088325af2e4c0bfad6c5f7

[DrunkOnJava]

📸 Media Enhancement Review

Excellent feature addition expanding the app's multimedia capabilities!

✅ Feature Scope

• Video Support: New Video model with proper storage/repository pattern
• Photo Editing: Basic crop/rotate functionality - essential features
• Integration: Proper CoreModule exposure and Item model updates
• User Experience: Video selection in Add Item flow enhances usability

🎯 Architecture Assessment

• Domain Model: Video model follows established patterns
• Repository Pattern: Consistent with existing makeVideoRepository approach
• Data Relationships: videoIds tracking on Item is well-designed
• Module Organization: Proper separation of concerns

⚠️ Technical Issues

• Build Problem: make test failing with "Bad substitution" error
• Testing: Need to verify video storage and photo editing functions work
• Performance: Consider video file size limits and storage optimization

💡 Recommendations

1. Fix Build Issues: Resolve Makefile substitution problems
2. File Size Limits: Implement video size restrictions for storage efficiency
3. Photo Editor: Consider adding filters or enhancement features later
4. Testing: Add unit tests for video repository and photo editing logic

📱 User Value

This significantly enhances the app by:

• Supporting modern multimedia inventory documentation
• Providing basic photo editing for better item photos
• Enabling video demonstrations of item functionality

Status: 🔶 VALUABLE FEATURE - NEEDS BUILD FIXES

[DrunkOnJava]

Code Review for PR #30: Add photo editing and video support

✅ Positive Changes

• Media Enhancement: Adds valuable photo editing and video recording capabilities to item management
• User Experience: Improves item documentation with rich media support
• Feature Completeness: Brings the app closer to comprehensive inventory management

⚠️ Issues Blocking Merge

This PR contains Foundation header compilation errors that prevent building:

1. Missing Foundation Headers: The PR introduces code that requires Foundation framework headers that aren't being imported correctly
2. Build Failures: CI shows compilation errors related to Foundation types and methods
3. Module Dependencies: Photo/video editing features may require additional framework imports (AVFoundation, Photos, etc.)

🔧 Recommendations

1. Fix Foundation Imports: Ensure all required framework headers are properly imported:

   import Foundation
   import AVFoundation
   import Photos
   import PhotosUI

2. Review Media Permissions: Verify proper permission handling for camera and photo library access

3. Test on Device: Photo/video features must be tested on physical devices, not just simulator

4. Error Handling: Implement robust error handling for media operations

📋 Merge Status

❌ Cannot merge - Build failures must be resolved first

This PR adds excellent functionality but needs Foundation framework issues fixed before merging. The media features will significantly enhance the user experience once the compilation errors are resolved.

[DrunkOnJava]

Closing this automated PR. Photo editing and video support features have been integrated into the media handling system. Thank you for the contribution!