Skip to content

Conversation

@adetoye-dev
Copy link
Contributor

@adetoye-dev adetoye-dev commented Sep 19, 2022

πŸ› οΈ Fixes Issue

Closes #133

πŸ‘¨β€πŸ’» Changes proposed

  • only show nav icons on mobile screen
  • make nav closable

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Web capture_19-9-2022_111349_localhost

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
code-magic βœ… Ready (Inspect) Visit Preview Sep 20, 2022 at 5:13AM (UTC)

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project by submitting a pull request

Make sure you filled the template properly and followed the rules in Contributing.md file, Thank you! Welcome to the community πŸ€“

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 19, 2022

How about you make it absolute and make it not take space so the rest of the important content has space still.

and on hover on the menu icon should be a cursor

@adetoye-dev
Copy link
Contributor Author

How about you make it absolute and make it not take space so the rest of the important content has space still.

and on hover on the menu icon should be a cursor

Alright, I'll make it absolute πŸ‘

Should it still display the icons when closed, or should only show the menu icon?

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 19, 2022

Alright, I'll make it absolute πŸ‘

Should it still display the icons when closed, or should only show the menu icon?

yes, the menu icon should show

@adetoye-dev
Copy link
Contributor Author

Alright, I'll make it absolute πŸ‘
Should it still display the icons when closed, or should only show the menu icon?

yes, the menu icon should show

Alright πŸ‘

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 19, 2022

also i think you don't understand conventional commits so here's a link that might help
https://gist.github.com/Zekfad/f51cb06ac76e2457f11c80ed705c95a3

@adetoye-dev
Copy link
Contributor Author

also i think you don't understand conventional commits so here's a link that might help https://gist.github.com/Zekfad/f51cb06ac76e2457f11c80ed705c95a3

Thanks 😁

@Dun-sin Dun-sin changed the title build: fix navbar responsiveness for mobile screens feat: fix navbar responsiveness for mobile screens Sep 19, 2022
@adetoye-dev
Copy link
Contributor Author

adetoye-dev commented Sep 19, 2022

How about now??

Web capture_19-9-2022_185834_localhost
Web capture_19-9-2022_1922_localhost

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 19, 2022

So much better

@Dun-sin Dun-sin changed the title feat: fix navbar responsiveness for mobile screens fix: navbar responsiveness for mobile screens Sep 19, 2022
Dun-sin
Dun-sin previously approved these changes Sep 19, 2022
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing

@Dun-sin
Copy link
Owner

Dun-sin commented Sep 19, 2022

On click on a generator, the menu should automatically close

@adetoye-dev
Copy link
Contributor Author

Looks good, thanks for contributing

Glad I could help πŸ˜‡

@adetoye-dev
Copy link
Contributor Author

On click on a generator, the menu should automatically close

Alright, I'll work on that πŸ‘

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much better, thank you

@Dun-sin Dun-sin merged commit b206243 into Dun-sin:main Sep 20, 2022
@Dun-sin
Copy link
Owner

Dun-sin commented Sep 20, 2022

πŸŽ‰ This PR is included in version 1.19.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@adetoye-dev
Copy link
Contributor Author

Nice, much better, thank you

You're welcome πŸ˜‡

@adetoye-dev adetoye-dev deleted the NavBarFix branch September 20, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] make it mobile responsive

2 participants