-
Notifications
You must be signed in to change notification settings - Fork 199
fix: navbar responsiveness for mobile screens #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Dun-sin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project by submitting a pull request
Make sure you filled the template properly and followed the rules in Contributing.md file, Thank you! Welcome to the community π€|
How about you make it absolute and make it not take space so the rest of the important content has space still. and on hover on the menu icon should be a cursor |
Alright, I'll make it absolute π Should it still display the icons when closed, or should only show the menu icon? |
yes, the menu icon should show |
Alright π |
|
also i think you don't understand conventional commits so here's a link that might help |
Thanks π |
|
So much better |
Dun-sin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for contributing
|
On click on a generator, the menu should automatically close |
Glad I could help π |
Alright, I'll work on that π |
Dun-sin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much better, thank you
|
π This PR is included in version 1.19.1 π The release is available on GitHub release Your semantic-release bot π¦π |
You're welcome π |


π οΈ Fixes Issue
Closes #133
π¨βπ» Changes proposed
βοΈ Check List (Check all the applicable boxes)
π Note to reviewers
π· Screenshots