Skip to content

Conversation

@thepushkaraj
Copy link
Contributor

πŸ› οΈ Fixes Issue

fix #183

πŸ‘¨β€πŸ’» Changes proposed

  • navbar is now closing when clicking outside of it.
  • used 'click' EventListener for achieving this.
  • used getComputedStyle() function to get display of '.menu' element.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

navbar is now closing when clicking outside of it. now close

fix Dun-sin#183
@vercel
Copy link

vercel bot commented Oct 2, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
code-magic βœ… Ready (Inspect) Visit Preview Oct 2, 2022 at 10:24AM (UTC)

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a Pull Request and contributing to our community project πŸŽ‰. Someone from the community will get back to you soon, usually within 24 hours

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks For Contributing, PR accepted, I hope you continue to contribute to this project

Check out the community discord server πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 22ee4e1 into Dun-sin:main Oct 2, 2022
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 2, 2022

πŸŽ‰ This PR is included in version 2.3.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] close navbar on clicking outside

2 participants