feat: add animation for NavBar in mobile view #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a sliding and opacity animation to the NavBar when closed/expanded in mobile view Dun-sin#209
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dun-sin
reviewed
Oct 4, 2022
Owner
Dun-sin
left a comment
Dun-sin
left a comment
There was a problem hiding this comment.
Thank you for creating a Pull Request and contributing to our community project 🎉. Someone from the community will get back to you soon, usually within 24 hours
Owner
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sliding and opacity animation to the NavBar when closed/expanded in mobile view.
For#209
🛠️ Fixes Issue
Fixes #209
👨💻 Changes proposed
Use
navBar?.animatewith keyframe options to animate a sliding effect as well as changing opacity.✔️ Check List (Check all the applicable boxes)
📄 Note to reviewers
Do you want me to animate the hamburger menu into the X? I can try doing that if you'd like(may or may not work)
Thanks!
📷 Screenshots
Screen_Recording_20221003-195019_Chrome.mp4