Skip to content

feat: Box Shadow generator #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dun-sin merged 10 commits into from
Oct 9, 2022
Merged

feat: Box Shadow generator #244

Dun-sin merged 10 commits into from
Oct 9, 2022

Conversation

@rupali-codes
Copy link
Contributor

@rupali-codes rupali-codes commented Oct 7, 2022

🛠️ Fixes Issue

Closes #138

👨‍💻 Changes proposed

  • added Box Shadow component in index.html
  • created src/pages/box-shadow-ts
  • updated src/lib/general.ts
    • generated function for Copying Code to clipbord and Inputting values
  • updated main.ts for calling boxShadowGenerator

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Inputting values
inputs-box-shadow

Output
result-box-shadow

@vercel
Copy link

vercel bot commented Oct 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
code-magic ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 1:54PM (UTC)

Dun-sin
Dun-sin reviewed Oct 7, 2022
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating a Pull Request and contributing to our community project 🎉. Someone from the community will get back to you soon, usually within 24 hours

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 7, 2022

you have some merge commits to fix

Dun-sin
Dun-sin reviewed Oct 7, 2022
View reviewed changes
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 7, 2022

Also, the input should be in one DIV, since they are the same input type
image

@rupali-codes
Copy link
Contributor Author

rupali-codes commented Oct 7, 2022

okay Dunsin, making my changes :)

@rupali-codes rupali-codes requested a review from Dun-sin October 8, 2022 15:34
Dun-sin
Dun-sin previously approved these changes Oct 9, 2022
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👌🏾 Thank you for contributing your PR is accepted, I hope you continue to contribute to this project

@rupali-codes
Copy link
Contributor Author

rupali-codes commented Oct 9, 2022

@Dun-sin why merging is still blocked 😥

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 9, 2022

@Dun-sin why merging is still blocked 😥

It's okay, I just fixed it

@Dun-sin Dun-sin merged commit d7d1bb0 into Dun-sin:main Oct 9, 2022
@Dun-sin
Copy link
Owner

Dun-sin commented Oct 9, 2022

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rupali-codes
Copy link
Contributor Author

rupali-codes commented Oct 9, 2022

Thank you Dunsin 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dun-sin Dun-sin Dun-sin approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Box shadow generator

2 participants

@rupali-codes @Dun-sin