-
Notifications
You must be signed in to change notification settings - Fork 105
Rework drops to use loot tables #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/resources/META-INF/accesstransformer.cfg
This was referenced Aug 9, 2022
This was referenced Aug 10, 2022
This was referenced Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks drops, replacing the drop creator system with one fully dependent on Vanilla's loot tables. This will allow loot modifiers to be used to modify tree drops, and is also much more intuitive for users who have previously used loot tables and wish to change tree drops as opposed to the tree itself.
It should be noted that this PR will break compatibility with all add-ons and tree packs that require drops, such that their drop creators will no longer be read and hence the trees will no longer drop anything. As such, this should not be merged/released until such a time that all add-ons are also ready for a compatibility update.
Features
blocksdirectory.oak_leaves.jsonfor oak leaves andcrimson_wart.jsonfor crimson wart blocks.LootTables#EMPTY(dropping nothing).seasonal_seed_drop_factor, which contains the current seasonal seed drop factor as calculated from the species.dynamictrees:seasonal_seed_drop_chance, has been added to drop based on the seasonal seed drop factor.trees/leavesdirectory.LootTables#EMPTY(dropping nothing).dynamictrees:leaves.trees/voluntarydirectory.LootTables#EMPTY(dropping nothing).dynamictrees:voluntary.dynamictrees:voluntary_seed_drop_chance, has been added to drop based on drop rate and season.trees/branchesdirectory._branchsuffix) with a suffix of the file extension.dynamictrees:branches.dynamictrees:multiply_logs_countanddynamictrees:multiply_sticks_count, have also been added to calculate the quantity of logs and sticks to drop based on the input volume.mainsource set.Closes #671