-
Couldn't load subscription status.
- Fork 4
Set up Nuget deploy pipeline #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Introduced a nuspec file and nuget.config for packaging DynamoVisualProgramming.PythonEngine.PythonNet3. Updated pipeline.yml to support NuGet deployment using a secret API key and new configuration files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR establishes a NuGet deployment pipeline for DynamoVisualProgramming.PythonEngine.PythonNet3 alongside the existing Dynamo Package Manager deployment. The changes introduce NuGet packaging configuration files and update the CI/CD pipeline to support automated NuGet publishing.
Key changes:
- Added NuGet package specification and configuration files
- Updated CI/CD pipeline to include NuGet deployment with API key credential handling
- Bumped version numbers across pipeline and build configuration files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pipeline.yml | Added NuGet deployment configuration with credentials and package settings |
| nuget.config | Defined NuGet package source pointing to the public NuGet repository |
| DynamoVisualProgramming.PythonEngine.PythonNet3.nuspec | Specified NuGet package metadata and file inclusions for the PythonNet3 engine |
| README.md | Documented the new NuGet deployment process and version management requirement |
| Directory.Build.props | Updated copyright year and version prefix to align with new release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I think you should be able to follow the pattern used by Player: |
Introduced a nuspec file and nuget.config for packaging DynamoVisualProgramming.PythonEngine.PythonNet3.
Updated pipeline.yml to support NuGet deployment.
I don't see a better way of doing it with CI, so that the Nuget and Dynamo package version match the binary version, but we will have to update
Directory.build.propsfile each time before deploying a new version. Hopefully we won't have to do it often.